Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for
additional_args
This plugin currently doesn't support searching within hidden files and directories. This makes it difficult to work with, say
.github/workflows/
directories and the like. Telescope's live_grep picker has a solution for this: additional_args. I would like to bring this feature to the live-grep-args extension. This will allow us to passadditional_args = { "--hidden" }
to this extension so that hidden files are included. We also get other benefits with the ability to pass other CLI flags.In this change,
additional_args
will be either a function or a table, so that it matches the signature of Telescope's live_grep picker. The implementation is just a copy of the one on live_grepAbout
vimgrep_arguments
Currently, my workaround is to use
vimgrep_arguments
. The problem with this is thatvimgrep_arguments
is not merged with the default value; it sets the entire thing. This is also the case in the telescope picker. Hence I have to set tovimgrep_arguments
the entire ripgrep CLI command. This solution is prone to breaking or becoming stale.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
make test
Configuration:
Checklist: