Fix irreproducible inference due to the imprecise floating point values in xgboost's get_dump

[pltb]

Tries to address the issues of using the output of the get_dump method in xgboost as the import format by parsing the output of save_model instead

More context here #497

TODO:

• parse using ObjectParser
• add more tests
• review from the plugin's authors

[wrigleyDan]

Summary of our chat at Haystack:

• Rename the parser to model/xgboost+json+raw
• Add the switch-case for the additional model parser
• Preserve existing functionality
• Add tests
• Documentation (Daniel)
• Add notebook to hello-ltr Github repo (Daniel)

[pltb]

@wrigleyDan a small correction: shall we rename it to model/xgboost+json+raw instead of v2?

[wrigleyDan]

@wrigleyDan a small correction: shall we rename it to model/xgboost+json+raw instead of v2?

Thanks, copied the old name and forgot to change it. Well spotted, corrected it in the comment above.

[pltb]

Hi @wrigleyDan, I've pushed a few changes that should cover the code-related action points that we've outlined:

• added 8 tests for some basic parsing cases (I'd love to see more extensive testing here, but I'm not sure if this should be a blocker for merging this version of the parser)
• added some extra validation and refactored the code a little bit
• renamed the parser like we've agreed
• registered the parser in the plugin

Please let me know if I can provide any assistance with the docs and/or the notebook, I'd be glad to help :D

[wrigleyDan]

Thanks for making the changes so quickly @pltb!
There are a couple of tasks failing when executing the tests around checkStyle:

> Task :checkstyleTest
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:56: Line is longer than 140 characters (found 152). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:115: Line is longer than 140 characters (found 152). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:173: Line is longer than 140 characters (found 152). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:227: Line is longer than 140 characters (found 152). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:282: Line is longer than 140 characters (found 152). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:336: Line is longer than 140 characters (found 152). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:397: Line is longer than 140 characters (found 152). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:458: Line is longer than 140 characters (found 152). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/test/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParserTests.java:511: Line is longer than 140 characters (found 152). [LineLength]

> Task :checkstyleTest FAILED

> Task :checkstyleMain
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:8:34: Using the '.*' form of import should be avoided - org.elasticsearch.xcontent.*. [AvoidStarImport]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:12:17: Using the '.*' form of import should be avoided - java.util.*. [AvoidStarImport]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:42: Line is longer than 140 characters (found 156). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:66: Line is longer than 140 characters (found 149). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:120: Line is longer than 140 characters (found 159). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:121: Line is longer than 140 characters (found 178). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:170: Line is longer than 140 characters (found 155). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:177:9: Redundant 'public' modifier. [RedundantModifier]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:197: Line is longer than 140 characters (found 149). [LineLength]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:217:9: Redundant 'public' modifier. [RedundantModifier]
[ant:checkstyle] [ERROR] /path/to/elasticsearch-learning-to-rank/src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java:248:9: Redundant 'public' modifier. [RedundantModifier]

> Task :checkstyleMain FAILED

Could you have a look and resolve these so we don't see any checkStyle violations when running the tests?

Thanks!

[pltb]

@wrigleyDan ah I totally missed it 😅
Fixed, thanks!

[wrigleyDan]

Thanks for the contribution and thanks for your patience @pltb
Merging this into main.
I will create two follow-up tasks:

• in this repo one to add documentation for this raw XGBoost parser
• in the hello-ltr repo to think about adding an example notebook

If you want to take a stab at them feel free to do so and/or let me know.