Fix when exception is raised, there is no Judgement object to store i…

…t in, so move that out of the service.

app/jobs/run_judge_judy_job.rb

@@ -24,14 +24,15 @@ def perform book, judge, number_of_pairs
       query_doc_pair = SelectionStrategy.random_query_doc_based_on_strategy(book, judge)
       break if query_doc_pair.nil?
 
+      judgement = Judgement.new(query_doc_pair: query_doc_pair, user: judge)
       begin
-        judgement = llm_service.make_judgement(judge, query_doc_pair)
+        judgement = llm_service.perform_judgement(judgement)
       rescue RuntimeError => e
         case e.message
         when /401/
           raise # we can't do anything about this, so pass it up
         else
-          judgement.explanation = "BOOM: #{e}" 
+          judgement.explanation = "BOOM: #{e}"
           judgement.unrateable = true
         end
       end

app/services/llm_service.rb

@@ -8,10 +8,10 @@ def initialize openai_key, _opts = {}
     @openai_key = openai_key
   end
 
-  def make_judgement judge, query_doc_pair
-    user_prompt = make_user_prompt query_doc_pair
-    results = get_llm_response user_prompt, judge.system_prompt
-    judgement = Judgement.new(query_doc_pair: query_doc_pair, user: judge)
+  def perform_judgement judgement
+    user_prompt = make_user_prompt judgement.query_doc_pair
+    results = get_llm_response user_prompt, judgement.user.system_prompt
+
     judgement.rating = results[:judgment]
     judgement.explanation = results[:explanation]
 

test/services/llm_service_test.rb

@@ -42,7 +42,8 @@ class LlmServiceTest < ActiveSupport::TestCase
     end
 
     test 'creating a judgement' do
-      judgement = service.make_judgement judge, query_doc_pair
+      judgement = Judgement.new(query_doc_pair: query_doc_pair, user: judge)
+      judgement = service.perform_judgement judgement
 
       assert_instance_of Float, judgement.rating
       assert_not_nil judgement.explanation