Properly nest returning judgements for a book under the book route #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d/judgements route
|
@david-fisher FYI, this was something I noticed when you fixed one of the notebooks, that the path to get the CSV was conceptually wrong. This PR fixes that pathing, and will need an update to the notebook ;-(. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move judgements.csv from /book/:id.csv to /book/:id/judgements.csv.
This matches up with the existing /book/:id/judgements.json API end point!
Motivation and Context
Be restful! Don't return book details in json and judgement details in csv at the same url!
Will need to fix Jupyterlite notebook to follow this pattern.