Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux docker start #25

Merged
merged 4 commits into from
Jan 27, 2022
Merged

Conversation

linuxswords
Copy link
Contributor

Adresses startup script for linux/docker users:

  • fix volume mount
  • changes permissions on solr_home for linux volume mount
  • use more portable shebang

@sstults
Copy link
Member

sstults commented Jan 27, 2022

I agree with the portable shebang part, but the chown makes the directory unreadable from the image. Not sure why this difference exists between Mac and Linux. We could check uname and only do chown if it's not Mac.

@linuxswords
Copy link
Contributor Author

@sstults Agreed and done on the uname and chown part. Added a hopefully clarifying comment and made the script pass shellcheck

@sstults sstults merged commit 693f91a into o19s:master Jan 27, 2022
@sstults
Copy link
Member

sstults commented Jan 27, 2022

Thank you @linuxswords this works perfectly. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants