go/runtime/bundle/manager: Cleanup key manager bundles on startup

oasisprotocol · Feb 12, 2025 · 0fed5e5 · 0fed5e5
1 parent b212a81
commit 0fed5e5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/.changelog/6062.bugfix.md b/.changelog/6062.bugfix.md
@@ -0,0 +1 @@
+go/runtime/bundle/manager: Cleanup key manager bundles on startup
diff --git a/go/runtime/bundle/manager.go b/go/runtime/bundle/manager.go
@@ -560,23 +560,20 @@ func (m *Manager) loadManifests() ([]*ExplodedManifest, error) {
 func (m *Manager) cleanOnStartup(manifests, exploded []*ExplodedManifest) ([]*ExplodedManifest, error) {
 	m.logger.Info("cleaning bundles")
 
-	detached := make(map[hash.Hash]struct{})
+	explodedHashes := make(map[hash.Hash]struct{})
 	for _, manifest := range exploded {
-		if manifest.IsDetached() {
-			detached[manifest.Hash()] = struct{}{}
-		}
+		explodedHashes[manifest.Hash()] = struct{}{}
 	}
 
 	shouldKeep := func(manifest *ExplodedManifest) bool {
 		if _, ok := m.runtimeIDs[manifest.ID]; !ok {
 			return false
 		}
-		if manifest.IsDetached() {
-			if _, ok := detached[manifest.Hash()]; !ok {
+		if manifest.IsDetached() || manifest.ID.IsKeyManager() {
+			if _, ok := explodedHashes[manifest.Hash()]; !ok {
 				return false
 			}
 		}
-
 		return true
 	}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		go/runtime/bundle/manager: Cleanup key manager bundles on startup