Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/bundle: Don't abort when some manifests cannot be loaded #6044

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 7, 2025

When upgrading from earlier versions the exploded bundle directory may contain non-bundle subdirectories which should not cause the loader to fail.

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit bd3e4c8
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/67a5c8086de5a200071de886

@kostko kostko force-pushed the kostko/fix/bundle-load-manifest-skip branch from 60b8b2a to 7a3d8fc Compare February 7, 2025 07:44
@kostko kostko marked this pull request as ready for review February 7, 2025 07:44
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.69%. Comparing base (b7bd71a) to head (7a3d8fc).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
go/runtime/bundle/manager.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6044      +/-   ##
==========================================
- Coverage   65.26%   64.69%   -0.58%     
==========================================
  Files         635      635              
  Lines       64604    64624      +20     
==========================================
- Hits        42167    41809     -358     
- Misses      17525    17907     +382     
+ Partials     4912     4908       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When upgrading from earlier versions the exploded bundle directory may
contain non-bundle subdirectories which should not cause the loader to
fail.
@kostko kostko force-pushed the kostko/fix/bundle-load-manifest-skip branch from 7a3d8fc to bd3e4c8 Compare February 7, 2025 08:44
Copy link
Contributor

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the problem, but the folder structure will remain invalid indefinitely. If any abnormalities occur, the cached folder should be completely wiped. Maybe we do that in another task.

@kostko
Copy link
Member Author

kostko commented Feb 7, 2025

Removing unknown stuff without letting the user know is always somewhat dangerous as the data could be useful. Maybe it is ok in this case since the whole directory is a cache, but let's defer this to another PR.

@kostko kostko enabled auto-merge February 7, 2025 09:25
@kostko kostko merged commit fd4f48e into master Feb 7, 2025
5 checks passed
@kostko kostko deleted the kostko/fix/bundle-load-manifest-skip branch February 7, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants