Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: List modules not loaded in Safe Mode check #139

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

prgmitchell
Copy link
Member

Description

List the modules not loaded as a result of Safe Mode being enabled.
Screenshot 2023-11-24 at 9 42 59 AM

Motivation and Context

This gives a user more visibility to what Safe Mode is preventing from loading.

How Has This Been Tested?

Tested with this log: https://obsproject.com/logs/AmHOz18shktiz0iV

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the commit message subject from "Include" to "List" to be clearer about what is actually happening.

checks/core.py Show resolved Hide resolved
@prgmitchell prgmitchell changed the title core: Include modules not loaded in Safe Mode check core: List modules not loaded in Safe Mode check Mar 14, 2024
List the modules not loaded as a result of Safe Mode being enabled.
@prgmitchell
Copy link
Member Author

Updated commit/PR title as well as the formatting of the modulesNotLoaded string.

@RytoEX
Copy link
Member

RytoEX commented Mar 14, 2024

Updated commit/PR title as well as the formatting of the modulesNotLoaded string.

The line breaks are rendering as spaces.
image

@prgmitchell
Copy link
Member Author

Updated commit/PR title as well as the formatting of the modulesNotLoaded string.

The line breaks are rendering as spaces. image

Sorry, this isn't something I am even seeing printed anywhere when testing so it has hard for me to validate...where are you seeing this output. This is the only output I see when testing:

image

@RytoEX
Copy link
Member

RytoEX commented Mar 14, 2024

Updated commit/PR title as well as the formatting of the modulesNotLoaded string.

The line breaks are rendering as spaces.

Sorry, this isn't something I am even seeing printed anywhere when testing so it has hard for me to validate...where are you seeing this output. This is the only output I see when testing:

I'm running loganalyzer.py directly from console.

@prgmitchell
Copy link
Member Author

@RytoEX I am extending a little bit past my Python knowledge here but I am thinking this has to do with how loganalyzer.py is displaying the results rather than how I am formatting them in my function. I've tried a few different ways to add a new line but none seem to reflect when displaying in the CLI. I didn't go through every function to look but I'm not seeing any examples in other functions that I checked where this is working either.

@RytoEX
Copy link
Member

RytoEX commented Mar 14, 2024

@RytoEX I am extending a little bit past my Python knowledge here but I am thinking this has to do with how loganalyzer.py is displaying the results rather than how I am formatting them in my function. I've tried a few different ways to add a new line but none seem to reflect when displaying in the CLI. I didn't go through every function to look but I'm not seeing any examples in other functions that I checked where this is working either.

It definitely fails in other functions, and I don't like it there either, probably because I have old history with web dev and I believe HTML should be formatted to be readable. For now, this isn't a blocker, but it will annoy me until I figure it out.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though I'd like to figure out how to make the console output nicer.

@RytoEX RytoEX merged commit 9fd1c4c into obsproject:master Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants