-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: List modules not loaded in Safe Mode check #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the commit message subject from "Include" to "List" to be clearer about what is actually happening.
752074b
to
0aca22d
Compare
List the modules not loaded as a result of Safe Mode being enabled.
549777a
to
fdeceab
Compare
Updated commit/PR title as well as the formatting of the modulesNotLoaded string. |
Sorry, this isn't something I am even seeing printed anywhere when testing so it has hard for me to validate...where are you seeing this output. This is the only output I see when testing: |
I'm running loganalyzer.py directly from console. |
@RytoEX I am extending a little bit past my Python knowledge here but I am thinking this has to do with how loganalyzer.py is displaying the results rather than how I am formatting them in my function. I've tried a few different ways to add a new line but none seem to reflect when displaying in the CLI. I didn't go through every function to look but I'm not seeing any examples in other functions that I checked where this is working either. |
It definitely fails in other functions, and I don't like it there either, probably because I have old history with web dev and I believe HTML should be formatted to be readable. For now, this isn't a blocker, but it will annoy me until I figure it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, though I'd like to figure out how to make the console output nicer.
Description
List the modules not loaded as a result of Safe Mode being enabled.
Motivation and Context
This gives a user more visibility to what Safe Mode is preventing from loading.
How Has This Been Tested?
Tested with this log: https://obsproject.com/logs/AmHOz18shktiz0iV
Types of changes
Checklist: