Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Check for permissions not granted on macOS #140

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

prgmitchell
Copy link
Member

@prgmitchell prgmitchell commented Nov 28, 2023

Description

Check for any permissions that are not granted on macOS and list them with a warning flag.
image

Motivation and Context

Suggested on the community Discord server.

How Has This Been Tested?

Tested logs with all permissions granted and with some missing.
https://obsproject.com/logs/cJpEIqQu07UoAdX1
https://obsproject.com/logs/rOK9qz0wdlw0KOQ3

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@prgmitchell prgmitchell force-pushed the macPerms branch 3 times, most recently from f06d17f to 822adaa Compare November 28, 2023 23:48
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting wording changes.

checks/macos.py Show resolved Hide resolved
checks/macos.py Outdated Show resolved Hide resolved
@prgmitchell prgmitchell force-pushed the macPerms branch 5 times, most recently from fc57739 to c4fb836 Compare March 15, 2024 00:44
Check for any permissions that are not granted on macOS and list them
with a warning flag.
@prgmitchell
Copy link
Member Author

Resolved changes requested

@RytoEX RytoEX self-assigned this Mar 15, 2024
@RytoEX RytoEX merged commit 5e42048 into obsproject:master Mar 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants