Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual library fixes #1273

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Conversation

jonludlam
Copy link
Member

No description provided.

@jonludlam jonludlam force-pushed the virtual-library-fixes branch from 832a026 to 6b4965d Compare January 13, 2025 15:53
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Comment on lines 78 to 80
intf unit list Util.StringMap.t ->
intf unit list Util.StringMap.t ->
intf unit list Util.StringMap.t
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add labels.

@jonludlam jonludlam force-pushed the virtual-library-fixes branch from 6ada525 to f746bbc Compare January 13, 2025 17:21
@jonludlam jonludlam added the no changelog This pull request does not need a changelog entry label Jan 13, 2025
@jonludlam jonludlam merged commit 85dd75a into ocaml:master Jan 13, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants