Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directories.0.6 #27328

Merged
merged 5 commits into from
Jan 30, 2025
Merged

directories.0.6 #27328

merged 5 commits into from
Jan 30, 2025

Conversation

zapashcanon
Copy link
Contributor

No description provided.

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for publishing the updates and looking after the upper bounds! :)

@zapashcanon
Copy link
Contributor Author

Thanks! I don't understand the error on Windows CI, is it something flaky we can ignore?

@shonfeder
Copy link
Contributor

Yeah, the windows error on bogue is due to a known problem with some libraries that depend on pkg-config (but that I think we have not yet clarified enough to have a solution or clear issue for):

  #=== ERROR while compiling conf-sdl2-image.1 ==================================#
  "pkg-config": command not found.

So definitely not related to this update!

@zapashcanon
Copy link
Contributor Author

Hmmm, now dune is not building. It seems unrelated (and a little bit scary :-))

@shonfeder
Copy link
Contributor

That dune error is definitely unrelated to these changes. It is also curious and on an old version of dune... I'll keep an eye out for recurrences of this.

@shonfeder
Copy link
Contributor

Thanks again for the updates!

@shonfeder shonfeder merged commit 7a7bf63 into ocaml:master Jan 30, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants