Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the opam lock command now exits with a non-zero exit code when dependencies are not yet installed in the current switch issue:#5520 reopened pr#6341 #6377

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

progressive-galib
Copy link

this might fix #5520

i mistakenly deleted the branch that was on #6341 thus i am re opening this pull request.

sorry for my silly mistake

@progressive-galib
Copy link
Author

@kit-ty-kate i am galib from #6341 (comment)

@kit-ty-kate
Copy link
Member

Hi, sorry but have you tested this code to make sure what you think it does? Reading it i can see this change doesn't do anything and i think it would be a better use of both of our time if things that you would like to work on were tested locally prior to sending it to us for review.

If you wish to learn OCaml from contributing to opam i think this is great, but i think most of the learning comes from reading the current code and testing what it does on your own, and only asking when you're stuck or the documentation is insufficient. If you jump to the last step without doing the former, there can only be so much actual learning from that.
For example from your question in #6341 (comment) if you read the code or tested it, you would see that OpamConsole.error does not raise any exception, it only displays a message on screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opam lock does not exit with an error code after displaying an error
2 participants