Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial ocaml on windows explanation #1600

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Conversation

patricoferris
Copy link
Contributor

This PR starts the explanation of the current state of OCaml on Windows fixing #1598. As a small disclaimer, I have never used Windows with OCaml and I don't have all of the context for the current (and future) work being done to improve OCaml on Windows. But hopefully this is a start so others can fill in the details if required.

cc: @dra27 who has been very helpful providing Windows feedback :))

@avsm
Copy link
Member

avsm commented Aug 4, 2021

I'm happy to merge this quickly and have followup PRs with refinements. Thanks Patrick!

@patricoferris
Copy link
Contributor Author

Sounds good to me if you are happy this information is accurate. I was going to ping the original folks on discuss but there wasn't much activity on the issue so might not be worth it :))

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Minor tweaky suggestions included...

Co-authored-by: David Allsopp <[email protected]>
@patricoferris
Copy link
Contributor Author

Thanks both :))

@dra27
Copy link
Member

dra27 commented Aug 4, 2021

Sorry - I messed up that URL… it’s got too many sets of brackets now!

@avsm avsm merged commit 76567a8 into ocaml:master Aug 5, 2021
@avsm
Copy link
Member

avsm commented Aug 5, 2021

thanks @patricoferris @dra27 !

@avsm
Copy link
Member

avsm commented Aug 5, 2021

Just a followup I noticed https://ocaml.org/docs/install.html#Windows should probably cross-link to this new updated info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants