feat: update to current best practices #394
Open
+69
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update esbuild to output ESM - Remove jest in favour of vitest - Don't add `@types/node` in the devDependencies to avoid having it leak into the outputted types
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
oscard0m
reviewed
Dec 29, 2024
| test: { | ||
| coverage: { | ||
| include: ["src/**/*.ts"], | ||
| exclude: ["src/methods/get-oauth-client-code.ts"], // Exclude this file from coverage as it isn't exported |
| @@ -3,14 +3,14 @@ export { createEsbuildScript }; | |||
| import { writePrettyFile } from "./write-pretty-file.js"; | |||
|
|
|||
| async function createEsbuildScript(answers) { | |||
| const nodeBuildOptions = ` // Build a CJS Node.js bundle | |||
| const nodeBuildOptions = ` // Build an ESM Node.js bundle | |||
There was a problem hiding this comment.
I feel we are at a point where we should test the output of running this script is the expected one. Do you think it's worth investing in this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/nodein the devDependencies to avoid having it leak into the outputted typesResolves #ISSUE_NUMBER
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!