fix: remove type imports from "http" for Deno compatibility (#221)

octokit · Apr 17, 2021 · 6a51895 · 6a51895
1 parent a7a293f
commit 6a51895
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 5 deletions.
diff --git a/src/middleware/node/middleware.ts b/src/middleware/node/middleware.ts
@@ -1,4 +1,8 @@
-import { IncomingMessage, ServerResponse } from "http";
+// remove type imports from http for Deno compatibility
+// see https://github.com/octokit/octokit.js/issues/24#issuecomment-817361886
+// import { IncomingMessage, ServerResponse } from "http";
+type IncomingMessage = any;
+type ServerResponse = any;
 
 import { parseRequest } from "./parse-request";
 

diff --git a/src/middleware/node/on-unhandled-request-default.ts b/src/middleware/node/on-unhandled-request-default.ts
@@ -1,4 +1,8 @@
-import { IncomingMessage, ServerResponse } from "http";
+// remove type imports from http for Deno compatibility
+// see https://github.com/octokit/octokit.js/issues/24#issuecomment-817361886
+// import { IncomingMessage, ServerResponse } from "http";
+type IncomingMessage = any;
+type ServerResponse = any;
 
 export function onUnhandledRequestDefault(
   request: IncomingMessage,

diff --git a/src/middleware/node/parse-request.ts b/src/middleware/node/parse-request.ts
@@ -1,4 +1,7 @@
-import { IncomingMessage } from "http";
+// remove type imports from http for Deno compatibility
+// see https://github.com/octokit/octokit.js/issues/24#issuecomment-817361886
+// import { IncomingMessage } from "http";
+type IncomingMessage = any;
 
 // @ts-ignore remove once Node 10 is out maintenance. Replace with Object.fromEntries
 import fromEntries from "fromentries";
@@ -41,7 +44,7 @@ export async function parseRequest(
     let bodyChunks: Uint8Array[] = [];
     request
       .on("error", reject)
-      .on("data", (chunk) => bodyChunks.push(chunk))
+      .on("data", (chunk: Uint8Array) => bodyChunks.push(chunk))
       .on("end", async () => {
         const bodyString = Buffer.concat(bodyChunks).toString();
         if (!bodyString) return resolve({ headers, query });

diff --git a/src/middleware/node/types.ts b/src/middleware/node/types.ts
@@ -1,4 +1,8 @@
-import { IncomingMessage, ServerResponse } from "http";
+// remove type imports from http for Deno compatibility
+// see https://github.com/octokit/octokit.js/issues/24#issuecomment-817361886
+// import { IncomingMessage, ServerResponse } from "http";
+type IncomingMessage = any;
+type ServerResponse = any;
 
 export type MiddlewareOptions = {
   pathPrefix?: string;