Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: modernize devDependencies #287

Merged
merged 9 commits into from
Jan 1, 2025
Merged

maint: modernize devDependencies #287

merged 9 commits into from
Jan 1, 2025

Conversation

wolfy1339
Copy link
Member

  • Switch to vitest
  • Switch to fetch-mock@11 from custom fork
  • Remove semantic-release from devDeps

Resolves #ISSUE_NUMBER


Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

* Switch to vitest
* Switch to fetch-mock@11 from custom fork
* Remove semantic-release from devDeps
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Dec 29, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak
Copy link

Uzlopak commented Dec 29, 2024

unfortunately i am not able to approve

@wolfy1339 wolfy1339 requested a review from oscard0m December 31, 2024 15:35
oscard0m
oscard0m previously approved these changes Dec 31, 2024
@wolfy1339
Copy link
Member Author

Now that conflicts are resolved this is good to go

@wolfy1339 wolfy1339 requested a review from oscard0m December 31, 2024 18:53
@wolfy1339 wolfy1339 merged commit 7752bbe into main Jan 1, 2025
7 checks passed
@wolfy1339 wolfy1339 deleted the dev-deps branch January 1, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants