Use long type for reading PunchCard statistics, just in case #2949
+58
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future-proofing. Just because, any time you have an arbitrary statistical counter, there could be some really big counts.
Before the change?
Numeric values deserialize as int32, using StatisticsClient.
After the change?
Numeric values deserialize as int64, using StatisticsClient.
Pull request checklist
I don't see any docs for the PunchCard classes, which are where the API changes are.
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
PunchCard and PunchCardPoint public constructors accepting the old int array parameter types are added, just for backward compatibility. But the return type of CommitCount and GetCommitCountFor do have to change to long, which I guess is unfortunately, technically breaking.