Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test for empty response with json media type #654

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Nov 29, 2023

Follow-up to #648

Resolves #ISSUE_NUMBER


Before the change?

After the change?

  • The test fully satisfies jest coverage
  • Sets the body option to an empty string ""

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Nov 29, 2023
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member Author

It seems there is already a test in place but it doesn't seem to cover the function properly for coverage

@wolfy1339 wolfy1339 changed the title test: add test for empty response with json media type test: fix test for empty response with json media type Nov 29, 2023
@wolfy1339 wolfy1339 merged commit 994980f into main Nov 30, 2023
7 checks passed
@wolfy1339 wolfy1339 deleted the add-test-pr-648 branch November 30, 2023 17:27
Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @8.x released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants