Correctly parse response bodies as JSON where the Content-Type is application/scim+json
#731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plication/scim+json`
GitHub has APIs that return `application/scim+json` response bodies. Currently, these responses are not parsed as JSON, and instead, an `ArrayBuffer` is returned in `response.data`.
This adds handling for `application/scim+json` so they are parsed as JSON as normal.
## Minimal reproduction
```js
import { Octokit } from "@octokit/rest";
import { enterpriseCloud } from "@octokit/plugin-enterprise-cloud";
const MyOctokit = Octokit.plugin(enterpriseCloud);
const myOctokit = new MyOctokit({
auth: "ghp_xxxxxxxx",
});
const resp = await myOctokit.request('GET /scim/v2/enterprises/{enterprise}/Groups', {
enterprise: 'fabrikam'
});
console.log(JSON.stringify(resp.data));
## Detailed changes
* Modify `getResponseData` function in `src/fetch-wrapper.ts` to include a check for `application/scim+json` content type.
* Refactor content type check into a new `isJSONResponse` function.
* Add a test in `test/request.test.ts` to verify that response bodies with `application/scim+json` content type are correctly parsed as JSON.
---
For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/octokit/request.js?shareId=XXXX-XXXX-XXXX-XXXX).
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
timrogers
commented
Jan 16, 2025
wolfy1339
approved these changes
Jan 16, 2025
|
🎉 This PR is included in version 9.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub has APIs that return
application/scim+jsonresponse bodies. Currently, these responses are not parsed as JSON, and instead, anArrayBufferis returned inresponse.data.This adds handling for
application/scim+jsonso they are parsed as JSON as normal.Minimal reproduction
Detailed changes
getResponseDatafunction insrc/fetch-wrapper.tsto include a check forapplication/scim+jsoncontent type.isJSONResponsefunction.test/request.test.tsto verify that response bodies withapplication/scim+jsoncontent type are correctly parsed as JSON.For more details, open the Copilot Workspace session.