Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kiota list command to install dependencies #33

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

kfcampbell
Copy link
Member

@kfcampbell kfcampbell commented Nov 7, 2023

Fixes #17.

Instead of hard-coding dependencies and their versions, this PR uses the kiota list command to get them.

⚠️ Note: ⚠️ in a very "production" application, this should use structs rather than interface{}s and it should be unit-tested, which it's not currently. @nickfloyd do you think we're at an appropriate stage where I should sharpen it like so? Is this just me being lazy? Are we in enough flux that I shouldn't do so yet and instead file an issue to tackle it after the alpha release?

@kfcampbell kfcampbell requested a review from nickfloyd November 7, 2023 23:35
@kfcampbell kfcampbell marked this pull request as ready for review November 7, 2023 23:35
@nickfloyd
Copy link
Collaborator

@nickfloyd do you think we're at an appropriate stage where I should sharpen it like so? Is this just me being lazy? Are we in enough flux that I shouldn't do so yet and instead file an issue to tackle it after the alpha release?

I still think we are grinding away at the concept here - though, thanks to Kiota and all of our previous work we have a solid direction, we are still ideating on how we want things to look and feel... I say we am to make "it" then come back around and make it better - I'm using this same approach with auth and headers - get it working then try it out, then get it working better.

@kfcampbell kfcampbell merged commit f343306 into main Nov 9, 2023
1 check passed
@kfcampbell kfcampbell deleted the kiota-list-deps branch November 9, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Kiota info command to install required dependencies
2 participants