-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-update the dotnet SDK #44
Conversation
@nickfloyd do you mind sharing the versions of .NET, Go, and Kiota you used to create the initial commit of the dotnet-sdk? I can reproduce these build errors locally. |
Ahh, I got it working locally. Builds should succeed with a version bump for Kiota's helpers, done in octokit/dotnet-sdk#2. In the future, we should do something for .NET like we do for Go in post-processing, where the latest versions of the helpers are always installed. That way, the helper package versions will keep updated in lockstep with Kiota versions and we can ensure compatability. |
Woohoo! The build is now successful and octokit/dotnet-sdk#3 has been created for the changes. I'm going to publish this PR now. @nickfloyd when you review, do you mind double-checking the namespacing? I may have messed something up, I'm seeing this in the diff: - namespace GitHub.Octokit.Advisories {
+ namespace Octokit.Client.Advisories { Maybe that's expected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick update to the namespace - all of the other extended source follows the GitHub prefix.
Co-authored-by: Nick Floyd <[email protected]>
This PR uses the
gr2m/create-or-update-pull-request-action@cd-path
Action to autogenerate commits to the octokit/dotnet-sdk repo.