Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update the dotnet SDK #44

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Auto-update the dotnet SDK #44

merged 6 commits into from
Dec 7, 2023

Conversation

kfcampbell
Copy link
Member

@kfcampbell kfcampbell commented Dec 6, 2023

This PR uses the gr2m/create-or-update-pull-request-action@cd-path Action to autogenerate commits to the octokit/dotnet-sdk repo.

@kfcampbell
Copy link
Member Author

@nickfloyd do you mind sharing the versions of .NET, Go, and Kiota you used to create the initial commit of the dotnet-sdk? I can reproduce these build errors locally.

@kfcampbell
Copy link
Member Author

Ahh, I got it working locally. Builds should succeed with a version bump for Kiota's helpers, done in octokit/dotnet-sdk#2.

In the future, we should do something for .NET like we do for Go in post-processing, where the latest versions of the helpers are always installed. That way, the helper package versions will keep updated in lockstep with Kiota versions and we can ensure compatability.

@kfcampbell
Copy link
Member Author

Woohoo! The build is now successful and octokit/dotnet-sdk#3 has been created for the changes. I'm going to publish this PR now.

@nickfloyd when you review, do you mind double-checking the namespacing? I may have messed something up, I'm seeing this in the diff:

- namespace GitHub.Octokit.Advisories {
+ namespace Octokit.Client.Advisories {

Maybe that's expected?

@kfcampbell kfcampbell marked this pull request as ready for review December 7, 2023 00:37
Copy link
Collaborator

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick update to the namespace - all of the other extended source follows the GitHub prefix.

.github/workflows/build-csharp.yml Outdated Show resolved Hide resolved
@kfcampbell kfcampbell requested a review from nickfloyd December 7, 2023 19:38
@kfcampbell kfcampbell merged commit 2c454f2 into main Dec 7, 2023
2 checks passed
@kfcampbell kfcampbell deleted the update-dotnet branch December 7, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants