Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to .net 8 sdk #393

Merged
merged 5 commits into from
Nov 20, 2023
Merged

chore(deps): upgrade to .net 8 sdk #393

merged 5 commits into from
Nov 20, 2023

Conversation

JamieMagee
Copy link
Contributor

The packages are still published as targeting .NET 6, but this change requires .NET 8 to build the packages. This allows us to take advantage some newer .NET features in a backwards compatible way.

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Directory.Build.props Outdated Show resolved Hide resolved
samples/AspNetCore/MyWebhookEventProcessor.cs Show resolved Hide resolved
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JamieMagee JamieMagee enabled auto-merge (squash) November 20, 2023 21:51
@JamieMagee JamieMagee merged commit 75e45b3 into main Nov 20, 2023
11 checks passed
@JamieMagee JamieMagee deleted the chore/dotnet-8 branch November 20, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants