Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target dotnet 9.0 for test and sample projects #611

Merged
merged 2 commits into from
Nov 20, 2024
Merged

target dotnet 9.0 for test and sample projects #611

merged 2 commits into from
Nov 20, 2024

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Nov 13, 2024

.NET 6 is now end-of-life. This change retargets sample and test projects to use .NET 9, while leaving the libraries targeting .NET 6.


Before the change?

  • All projects target .NET 6

After the change?

  • Test and sample projects target .NET 9

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

No

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@JamieMagee JamieMagee changed the title target dotnet 8.0 for test and sample projects target dotnet 9.0 for test and sample projects Nov 13, 2024
@JamieMagee JamieMagee marked this pull request as ready for review November 13, 2024 19:25
@JamieMagee JamieMagee enabled auto-merge (squash) November 14, 2024 00:04
Copy link
Contributor

@lineville lineville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review might not count for much here, but LGTM!

@JamieMagee JamieMagee merged commit 8e6d2f0 into main Nov 20, 2024
7 checks passed
@JamieMagee JamieMagee deleted the dotnet-8.0 branch November 20, 2024 18:44
king-2929

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants