Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] chart panel: wrongly aligned ColorPicker #2809

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Aug 18, 2023

Description

Since a component ColorPickerWidget was created, the color picker icon was misaligned with its text in the chart side panels. Fix this issue.

Task:

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : 3380585

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #2807

Since a component ColorPickerWidget was created, the color picker icon was
misaligned with its text in the chart side panels. Fix this issue.

Task: 3380585
X-original-commit: 88c53ba
@robodoo
Copy link
Collaborator

robodoo commented Aug 18, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Aug 18, 2023

@hokolomopo @rrahir this PR targets saas-16.4 and is the last of the forward-port chain.

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@rrahir
Copy link
Collaborator

rrahir commented Aug 18, 2023

@fw-bot r+

@robodoo robodoo temporarily deployed to merge August 18, 2023 06:40 Inactive
@robodoo robodoo closed this in 0033e7c Aug 18, 2023
@fw-bot fw-bot deleted the saas-16.4-saas-16.3-fix-colorpicker-widget-position-adrm-kj6M-fw branch September 1, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants