Merge pull request #622 from oduwsdl/issue-620

Use system supplied temp dir instead of hardcoded /tmp

ipwb/__main__.py

@@ -1,6 +1,7 @@
 import sys
 import os
 import argparse
+import tempfile
 import string  # For generating a temp file for stdin
 import random  # For generating a temp file for stdin
 from .__init__ import __version__ as ipwbVersion
@@ -46,7 +47,7 @@ def checkArgs_replay(args):
 
         random.seed()
         # Write data to temp file (sub-optimal)
-        tempFilePath = '/tmp/' + ''.join(random.sample(
+        tempFilePath = tempfile.gettempdir() + '/' + ''.join(random.sample(
               string.ascii_uppercase + string.digits * 6, 12)) + '.cdxj'
         with open(tempFilePath, 'w') as f:
             f.write(cdxjIn)

ipwb/indexer.py

@@ -20,6 +20,7 @@
 import surt
 import ntpath
 import traceback
+import tempfile
 
 from io import BytesIO
 from warcio.archiveiterator import ArchiveIterator
@@ -115,7 +116,7 @@ def encrypt(hstr, payload, encryptionKey):
 
 
 def createIPFSTempPath():
-    ipfsTempPath = '/tmp/ipfs/'
+    ipfsTempPath = tempfile.gettempdir() + '/ipfs/'
 
     # Create temp path for ipwb temp files if it does not already exist
     if not os.path.exists(ipfsTempPath):

ipwb/replay.py

@@ -20,6 +20,7 @@
 import re
 import signal
 import traceback
+import tempfile
 
 from flask import Flask
 from flask import Response
@@ -61,7 +62,7 @@
 from flask import send_from_directory
 from flask import make_response
 
-UPLOAD_FOLDER = '/tmp'
+UPLOAD_FOLDER = tempfile.gettempdir()
 ALLOWED_EXTENSIONS = ('.warc', '.warc.gz')
 
 app = Flask(__name__)

tests/testUtil.py

@@ -2,6 +2,7 @@
 import random
 import string
 import re
+import tempfile
 
 from time import sleep
 
@@ -56,7 +57,7 @@ def startReplay(warcFilename):
     global p
     pathOfWARC = os.path.join(os.path.dirname(__file__) +
                               '/../samples/warcs/' + warcFilename)
-    tempFilePath = '/tmp/' + ''.join(random.sample(
+    tempFilePath = tempfile.gettempdir() + '/' + ''.join(random.sample(
         string.ascii_uppercase + string.digits * 6, 12)) + '.cdxj'
 
     open(tempFilePath, 'a').close()  # Create placeholder file for replay