Fix group listing: don't add root every time #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Fulchir <[email protected]>
|
related to ticket #44 |
|
Hi, @ogham , any update on this? I think this is a good fixing :-D |
|
Run into this as well and it's extremely annoying. @ogham hasn't done any commits since 2021, which makes me wonder if this repo is just abandoned and if so if anyone could take this one over? |
sholderbach
pushed a commit
to nushell/nushell
that referenced
this pull request
Jun 30, 2023
# Description Fixes: #9498 Actually we don't need this pr if the upstream pr is merged: ogham/rust-users#45 But it doesn't have any commit since 2021, and the author seems not active on github now, I think we have to copy the function into nushell to get relative issue fixed...
|
Since this project is unmaintained, I forked to https://github.com/rustadopt/uzers-rs where I for example merged this PR and maintain it from now on. It's also available in v0.11.2 on https://crates.io/crates/uzers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vector of all gids should be resized (and sorted, deduped) before we translate it to the returned group list
Signed-off-by: Luca Fulchir [email protected]