Show new line in comments #10004
Show new line in comments #10004
Conversation
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/components/Resource/ResourceCommentSection.tsx (1)
Line range hint
97-100: Fix Avatar name prop using incorrect name fields.The Avatar component is using
first_nametwice instead of using bothfirst_nameandlast_name.- name={`${created_by.first_name} ${created_by.first_name}`} + name={`${created_by.first_name} ${created_by.last_name}`}
🧹 Nitpick comments (1)
src/components/Resource/ResourceCommentSection.tsx (1)
92-92: Consider normalizing all whitespace characters.While the current implementation handles newlines well, you might want to consider normalizing other whitespace characters for consistency.
- {comment.replace(/\n+/g, "\n")} + {comment.replace(/[\s\n]+/g, " ").replace(/\n+/g, "\n").trim()}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/Resource/ResourceCommentSection.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: cypress-run (1)
- GitHub Check: OSSAR-Scan
🔇 Additional comments (1)
src/components/Resource/ResourceCommentSection.tsx (1)
91-93: LGTM! Changes effectively implement newline preservation.The combination of
whitespace-pre-wrapclass and newline normalization successfully addresses the issue of preserving line breaks in comments while maintaining clean formatting.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/Resource/ResourceCommentSection.tsx (1)
95-96: Consider preserving intentional double newlines.The current implementation consolidates all consecutive newlines into a single newline. While this prevents excessive spacing, it might remove intentional paragraph breaks (double newlines).
Consider this alternative approach:
- {comment.replace(/\n+/g, "\n")} + {comment.replace(/\n{3,}/g, "\n\n")}This preserves double newlines for paragraph breaks while still consolidating 3 or more newlines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/Resource/ResourceCommentSection.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: cypress-run (1)
🔇 Additional comments (2)
src/components/Resource/ResourceCommentSection.tsx (2)
14-14: LGTM! Import statement correctly updated.The
relativeTimeutility function is properly imported alongside the existingformatNamefunction.
88-92: LGTM! Component signature and layout updated correctly.The Comment component has been properly updated to:
- Accept the new
created_dateprop- Display the author info and timestamp in a well-structured layout
Also applies to: 99-101, 103-109
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/Resource/ResourceCommentSection.tsx (1)
95-97: Consider a more robust whitespace handling approach.While the current implementation handles multiple newlines, consider these improvements:
- Handle other whitespace characters (spaces, tabs) that might cause formatting issues
- Preserve intentional paragraph breaks (double newlines)
- <p className="break-words whitespace-pre-wrap"> - {comment.replace(/\n+/g, "\n")} + <p className="break-words whitespace-pre-wrap"> + {comment + .replace(/[\t ]+/g, " ") // normalize spaces and tabs + .replace(/\n{3,}/g, "\n\n") // preserve double newlines for paragraphs + .trim()}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/Resource/ResourceCommentSection.tsx(2 hunks)
🔇 Additional comments (4)
src/components/Resource/ResourceCommentSection.tsx (4)
14-14: LGTM!The addition of the
relativeTimeimport is appropriate for the new date formatting functionality.
88-92: LGTM!The Comment component signature has been properly updated to include the
created_dateprop with appropriate TypeScript typing.
100-108: LGTM!The user info section is well-structured with proper alignment and spacing. The Avatar component now correctly uses first_name and last_name.
109-109: Remove italic styling as per previous feedback.Jacobjeevan previously commented: "Let's not add italics (doesn't fit with our current design anyways)."
- <div className="italic text-xs">{relativeTime(created_date)}</div> + <div className="text-xs">{relativeTime(created_date)}</div>
…-dev/care_fe into issue/9984/comment-newline
Proposed Changes
BEFORE
AFTER
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit