Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes address and patient note card multi-line issue #9607

Merged
merged 2 commits into from
Dec 30, 2024
Merged

fixes address and patient note card multi-line issue #9607

merged 2 commits into from
Dec 30, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 30, 2024 •
edited by coderabbitai bot
Loading

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features

    • None

  • Bug Fixes

    • Improved text formatting in patient note display by preserving whitespace and line breaks
    • Removed automatic form submission on "Enter" key press

  • Style

    • Added whitespace-pre-wrap class to patient note text rendering

@rithviknishad rithviknishad requested a review from a team as a code owner December 30, 2024 04:02
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2024 •
edited
Loading

Walkthrough

This pull request introduces two modifications: first, in the PatientNoteCard component, a whitespace-pre-wrap class is added to improve text formatting, allowing better preservation of whitespace and line breaks in note content. Second, in the Form component, the onKeyDown event handler for form submission is removed, which means pressing "Enter" will no longer automatically submit the form.

Changes

File Change Summary
src/components/Facility/PatientNoteCard.tsx Added whitespace-pre-wrap class to note text rendering for improved text formatting
src/components/Form/Form.tsx Removed onKeyDown event handler that previously allowed form submission via "Enter" key

Assessment against linked issues

Objective Addressed Explanation
Support multi-lines in doctor notes ✅
Display text in multiple lines ✅

Possibly related PRs

Suggested labels

needs review, tested

Suggested reviewers

  • Jacobjeevan

Poem

🐰 A rabbit's tale of code so neat,
Whitespace dancing, lines now sweet
No more Enter key's hasty might
Forms and notes now shine so bright
Coding magic, line by line! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94585fd and 8a898f4.

📒 Files selected for processing (2)
  • src/components/Facility/PatientNoteCard.tsx (1 hunks)
  • src/components/Form/Form.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • src/components/Form/Form.tsx
✅ Files skipped from review due to trivial changes (1)
  • src/components/Facility/PatientNoteCard.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 8a898f4
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67721b6096dc7b00084568eb
😎 Deploy Preview https://deploy-preview-9607--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Dec 30, 2024
@rithviknishad rithviknishad mentioned this pull request Dec 30, 2024
Closed
2 tasks
@cypress Cypress
Copy link

cypress bot commented Dec 30, 2024

CARE    Run #4103

Run Properties:  status check passed Passed #4103  •  git commit 8a898f41ff: fixes address and patient note card multi-line issue
Project CARE
Branch Review rithviknishad/fix/9592
Run status status check passed Passed #4103
Run duration 04m 32s
Commit git commit 8a898f41ff: fixes address and patient note card multi-line issue
Committer Rithvik Nishad
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 135
View all changes introduced in this branch ↗︎

@khavinshankar khavinshankar merged commit 709d866 into develop Dec 30, 2024
58 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/9592 branch December 30, 2024 04:20
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

This was referenced Dec 30, 2024
Merged
Open
Open
Merged
Merged
Merged
Merged
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Patient Registration & Doctor Notes is not supporting multi-lines
3 participants
@rithviknishad @khavinshankar @nihal467