-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solved #20 i.e contact link is now working from other than homepage #21
Open
thecodephilic-guy
wants to merge
15
commits into
ohcnetwork:main
Choose a base branch
from
thecodephilic-guy:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0a193e4
solved #20 i.e contact link is now working from other than homepage
thecodephilic-guy a24f295
fixed the improper behavior of footer in production
thecodephilic-guy 7764dda
Merge branch 'ohcnetwork:main' into main
thecodephilic-guy a520c9a
removed scroll behaviour from footer and fixed contact link behaviour
thecodephilic-guy f99dad3
Merge branch 'ohcnetwork:main' into main
thecodephilic-guy 6fcf2ec
Merge branch 'ohcnetwork:main' into main
thecodephilic-guy c7c43a3
Solved the navigation problem using Link tag
thecodephilic-guy 848b5ee
made some changes in pages/index.js to make contact link work.
thecodephilic-guy c2c3008
Merge branch 'ohcnetwork:main' into main
thecodephilic-guy acac58d
Merge branch 'ohcnetwork:main' into main
thecodephilic-guy 8f11131
Merge remote-tracking branch 'origin/main'
thecodephilic-guy c451c3f
Merge remote-tracking branch 'origin/main'
thecodephilic-guy ed1c38e
Merge remote-tracking branch 'origin/main'
thecodephilic-guy 100472d
Merge remote-tracking branch 'origin/main'
thecodephilic-guy d363ee2
Merge remote-tracking branch 'origin/main'
thecodephilic-guy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bit overkill for a small issue. Let's stick to just taking the user to /#contact without the scroll behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah actually it is and I have rolled my to previous one. But I am still struggling with the problem that it is not taking to the /#contact when user is on supporters page or may be care page. I tried faking the network speed during development it worked there but only for localhost. I need some more time to go to the core of the problem. I have the intuation it is just a minor one but I am not able to get it.