Add: Identify First-Time PR Contributors for Last Week

[JavidSumra]

Fixes #153

Description

This PR implements logic to identify first-time PR contributors whose first pr_merged activity occurred within the specified time frame (last week). It ensures accuracy by filtering contributors based on their activities and checks if their first contribution happened during last week.

Screenshots / Outputs

[netlify]

👷 Deploy request for leaderboard-develop pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	abb4350

[rithviknishad]

instead of directly keeping the logic here, let's add it to the contributor object itself. so that this value isNewContributor could be reused everywhere else when needed.

[rithviknishad]

Also not a fan of the design. Let's not have @, seems out of context. Also placing above the name doesn't seem nice.

[JavidSumra]

instead of directly keeping the logic here, let's add it to the contributor object itself. so that this value isNewContributor could be reused everywhere else when needed.

Shall I add this logic in getContributorBySlug function?

[rithviknishad]

yup! that's the right place to be

[JavidSumra]

@rithviknishad can you please review this PR?

[rithviknishad]

use Set instead to handle duplicates.

[JavidSumra]

Could you please explain why a set is needed in this case? We're simply adding the top contributors to highlight them for the week, right? Since the isNewContributor attribute prevents duplication, isn't that sufficient?

[rithviknishad]

sufficient yes, but it's just cleaner than too many spread operations and filters. more readable the code is, the better.

[JavidSumra]

I believe spread operators and filters are necessary since it’s an array of objects, and sets wouldn’t be usable in this case for the filtering process, right?

[rithviknishad]

why wrap in date?

Suggested change

	.sort((a, b) => compareAsc(new Date(a.time), new Date(b.time)))[0];
	.sort((a, b) => compareAsc(a.time, b.time))[0];

[JavidSumra]

@rithviknishad compareAsc expects arguments of type Date or number, so I wrapped the value in a Date instead of converting it from a string to a number.