Feature: Allow users to edit chat thread title #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuliohome
commented
Sep 22, 2023
•
giuliohome
commented
Ali-Parandeh
suggested changes
Oct 19, 2023
| useEffect(() => { | ||
| const fetchData = async () => { | ||
| console.log("fetching items") |
| useEffect(() => { | ||
| const fetchData = async () => { | ||
| console.log("fetching items") | ||
| const data = await FindAllChatThreadForCurrentUser(); |
There was a problem hiding this comment.
Does this function handle fetching errors?
|
|
||
| const doRefresh = () => { | ||
| console.log("should refresh") |
|
|
||
| const doRefresh = () => { | ||
| console.log("should refresh") | ||
| setRefresh(!refresh); |
There was a problem hiding this comment.
Suggested change
| setRefresh(!refresh); | |
| setRefresh(prev => !prev) |
Comment on lines
+33
to
+35
|
|
||
| # secrets | ||
| start.sh |
| @@ -21,6 +22,11 @@ export const MenuItems: FC<Prop> = (props) => { | |||
| router.replace("/chat"); | |||
| }; | |||
|
|
|||
| const renameTitle = async (threadID: string, title: string) => { | |||
| await userUpdateThreadTitle(threadID, title); | |||
| @@ -45,6 +51,20 @@ export const MenuItems: FC<Prop> = (props) => { | |||
| <span className="flex gap-2 items-center overflow-hidden flex-1"> | |||
| <span className="overflow-ellipsis truncate"> {thread.name}</span> | |||
There was a problem hiding this comment.
You're truncating thread names. If thread names are longer than 30 characters you will want to render ellipses here perhaps (...)
| const chatThread = threads[0] | ||
| await UpsertChatThread({ | ||
| ...chatThread, | ||
| name: userTitle.substring(0, 30), |
There was a problem hiding this comment.
Instead of truncating here, prevent user from putting down more than 30 characters. That way we don't store truncated names in database. i.e. Review legal documents around tax fil
|
@Ali-Parandeh
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.