Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shapefile #46

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

Shapefile #46

wants to merge 65 commits into from

Conversation

floriandeboissieu
Copy link
Contributor

@floriandeboissieu floriandeboissieu commented Jan 19, 2021 •
edited
Loading

Hi Olivier,
I made several enhancements to peps_download after packaging, see below list. I tried to keep as much as possible as your code.
Although geopandas is supported, it is not required. If not available, setting shape argument will just raise an error.

You can install and try the package with command line:

pip install git+https://github.com/floriandeboissieu/peps_download.git@shapefile

v1.0.0

Add

  • pip install support
  • multipage requests
  • argument shape as file (shapefile, geojson, ...), shapely geometry, or geopandas object to define bounding box
  • control of verbosity
  • NEWS.md for future updates

Change

  • return file status ('on tape', 'staging', 'on disk', 'downloaded', 'existing')
  • update README

@floriandeboissieu
encapsulated peps_download script in pep_download function
fe1bdca
@floriandeboissieu
fix main with Exceptions other than SysError
a8b1fb4
@floriandeboissieu
add documentation
6dc4ab6
@floriandeboissieu
add setup.py
0fa4238
@floriandeboissieu
reordered command lin options for ease of use
e2e0262
@floriandeboissieu
remove windows option as it can be checked internally with package pl…
c402626 
…atform
@floriandeboissieu
fix max_trials
975282b
@floriandeboissieu
Merge branch 'master' into pip_install
1641231
@floriandeboissieu
add shape option/argument for polygon file support
b62940b
@floriandeboissieu
add shape option/argument for polygon file support
ca7ffc9
@floriandeboissieu
add shape option/argument for any vector file support
b943665
@floriandeboissieu
add shape option/argument for any vector file support
c0bddaa
@floriandeboissieu
remove windows option as it can be checked internally with package pl…
2887af9 
…atform
@floriandeboissieu
Merge branch 'pip_install' into shapefile
ac8c21d
@floriandeboissieu
add fix shape error
2c396df
@floriandeboissieu
set argument extract=True as default in peps_download function
4c7fb7f
@floriandeboissieu
fix conflict on extract default value
17713c4
@floriandeboissieu
fix print error on trials
b2b1674
@floriandeboissieu
Merge branch 'master' into pip_install
9d3ec8e
@floriandeboissieu
Merge branch 'pip_install' into shapefile
77b4417
@floriandeboissieu
change output of peps_download
c3927e1
@floriandeboissieu
change output of peps_download
a1d9816
@floriandeboissieu
change output of peps_download
8b97fc2
@floriandeboissieu
change output of peps_download
566c010
@floriandeboissieu
change output of peps_download
ea47003
@floriandeboissieu
remove prod from returns of parse_catalog: prod was last iteration …
673b09d 
…of a for loop inside parse_catalog, which seems useless outside parse_catalog
@floriandeboissieu
add shape option (shape_file argument in function peps
20787c6
@floriandeboissieu
add support of shape arg as geopandas GeoSeries and GeoDataFrame
a91d46e
@floriandeboissieu
add install section to README.md
33eaae3
@floriandeboissieu
add support shapely polygon and point for shape arg
55110bb
@floriandeboissieu
fix messages at teh end of catalog search and downloading phase
468cba1
@floriandeboissieu
fix 2nd search catalog removing search_json_file before running command
e519c45
@floriandeboissieu
fix 2nd search catalog while
e7e19c5
@floriandeboissieu
modularized code, add 'downloaded' to status, add storage_dict to ouputs
8d6ea75
@floriandeboissieu
replace storage_dict by status_dict for comprehension
59bcfa8
@floriandeboissieu
update documentation of return
51df40a
@floriandeboissieu
fix statistics
e561d6b
@floriandeboissieu
fix statistics
389b430
@floriandeboissieu
fix statistics
7791caf
@floriandeboissieu
fix statistics
503f20d
@floriandeboissieu
add verbose arg to peps_download
6897397
@floriandeboissieu
generalize arg shape to shapely geometry of any type
d2677bb
@floriandeboissieu
add verbose arg around most prints
f415007
@floriandeboissieu
add verbose arg around most prints
dc5a7e6
@floriandeboissieu
add verbose arg around most prints
1f8009e
@floriandeboissieu
remove authentication necessity for no_download=True
226a3a4
@floriandeboissieu
replace os.system by subprocess.check_call
c42e249
@floriandeboissieu
fix parse_catalog when no products found
8715f97
@floriandeboissieu
remove sleeping time in search_query
58327f7
@floriandeboissieu
Merge remote-tracking branch 'upstream/master' into shapefile
302627e 
merge Olivier Hagolle updates
@floriandeboissieu
update collection default to S2ST and warnings, see commit #bb66f9e
eb0c09d
@floriandeboissieu
update command line doc
b454b2d
@floriandeboissieu
add example for python API
a36f8bd
@floriandeboissieu
update README command line examples as peps_download.py is directly c…
12d73e8 
…allable with pip installed package
@floriandeboissieu
add NEWS.md for future updates
f1e1470
@floriandeboissieu
add NEWS.md for future updates
80d0648
@floriandeboissieu
add NEWS.md for future updates
b45d495
@floriandeboissieu floriandeboissieu mentioned this pull request Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@floriandeboissieu