[6.2]feat: bump jaxb to 4 and dynamic generate code #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miurahr
added
enhancement
build/release
refactoring
dependencies
|
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
- Drop jaxb generated files from repository - Update task dependency to use generated code - Tweak JAXB generation code difference; filters.getFilters() -> getFilter() - Tweak JAXB api package from javax.xml.* to jakarta.xml.* - Bump [email protected] which based on JAXB 4 - Update javax.xml.bind:jaxb.xml.bind-api:2.0.5 to jakarta.xml.bind:jakarta.xml.bind-api:4.0.2 - Update org.glassfish.jaxb:jaxb-xjc:2.3.1 to org.glassfish.jaxb:jaxb-xjc:4.0.5 - Update org.glassfish.jaxb:jaxb-runtime:2.3.0 to org.glassfish.jaxb:jaxb-runtime:4.0.5 - Update com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.16.1 to com.fasterxml.jackson.module:jackson-module-jakarta-xmlbind-annotations:2.16.1 Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/gen/bump-jaxb-4
branch
from
a31ccf1 to
8063169
Compare
miurahr
changed the title
|
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
miurahr
commented
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 9 and later drops JAXB from Java runtime.
JAXB standard is now version 4 but OmegaT depends version 2 which is bundled version of Java 8.
OmegaT 6.1.0_beta and later moves to Java 11, so we can update JAXB 4.
There is a package
jakarta.xml.bindin JAXB 4 instead ofjavax.xml.bindin JAXB 2, so we need to modify source code.Pull request type
Which ticket is resolved?
What does this PR change?
Drop jaxb generated files from repository
Update task dependency to use generated code
Tweak JAXB generation code difference; filters.getFilters() -> getFilter()
Tweak JAXB api package from javax.xml.* to jakarta.xml.*
Bump [email protected] which based on JAXB 4
Update javax.xml.bind:jaxb.xml.bind-api:2.0.5 to jakarta.xml.bind:jakarta.xml.bind-api:4.0.2
Update org.glassfish.jaxb:jaxb-xjc:2.3.1 to org.glassfish.jaxb:jaxb-xjc:4.0.5
Update org.glassfish.jaxb:jaxb-runtime:2.3.0 to org.glassfish.jaxb:jaxb-runtime:4.0.5
Update com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.16.1 to com.fasterxml.jackson.module:jackson-module-jakarta-xmlbind-annotations:2.16.1
Other information