Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-format skip sections #651

Merged
merged 2 commits into from
Dec 9, 2016
Merged

Re-format skip sections #651

merged 2 commits into from
Dec 9, 2016

Conversation

mpharrigan
Copy link
Contributor

Per http://conda.pydata.org/docs/building/meta-yaml.html#skipping-builds I've put all the skips as comments.

I've put them on one line, so you can grep for "skip: " and get a quick summary of what's not getting built.

If there's a comment explaining the skip, put it on one line before (so you can grep -B1).

We should make people explain their skips. There are a lot of skipped configurations whose reasoning is not obvious at all. This is important if someone wants to fix it

@jchodera
Copy link
Member

jchodera commented Dec 9, 2016

Or should this be merged first?

@mpharrigan
Copy link
Contributor Author

Let's do #650 first, then this, then leave #652 open until everything supports py3

@jchodera jchodera merged commit 73f28ef into omnia-md:master Dec 9, 2016
@mpharrigan mpharrigan deleted the skip branch December 9, 2016 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants