Fix Dataprep Ingest Data Issue. #1271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trace: 1. The update of `langchain_huggingface.HuggingFaceEndpointEmbeddings` caused the wrong size of embedding vectors. 2. Wrong size vectors are wrongly saved into Redis database in type of `byte`, and the indices are not created correctly. 3. The retriever can not retrieve data from Redis using index due to the reasons above. 4. Then the RAG seems `not work`, for the file uploaded can not be retrieved from database. Solution: Replace all of the `langchain_huggingface.HuggingFaceEndpointEmbeddings` to `langchain_community.embeddings.HuggingFaceInferenceAPIEmbeddings`, and modify related READMEs and scirpts. Related issue: opea-project/GenAIExamples#1482 Signed-off-by: letonghan <[email protected]>
letonghan
requested review from
XinyuYe-Intel,
lvliang-intel,
ftian1 and
chensuyue
as code owners
for more information, see https://pre-commit.ci
lianhao
requested changes
Feb 7, 2025
|
One more thing, I noticed that retriever is also using the |
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
The |
Signed-off-by: letonghan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Dataprep Ingest Data Issue.
Root Cause:
The package of
langchain_huggingfaceupdated, caused different output ofHuggingFaceEndpointEmbeddings.embed_documents.Trace:
langchain_huggingface.HuggingFaceEndpointEmbeddingscaused the wrong size of embedding vectors.not work, for the file uploaded can not be retrieved from database.Solution:
Replace all of the
langchain_huggingface.HuggingFaceEndpointEmbeddingstolangchain_community.embeddings.HuggingFaceInferenceAPIEmbeddings, and modify related READMEs and scirpts.Issues
opea-project/GenAIExamples#1473
opea-project/GenAIExamples#1482
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Local tested