Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally support ARM setup #1232

Closed
wants to merge 7 commits into from
Closed

Conversation

raravena80
Copy link

Description

Changes needed to support ARM without rerank with specific embeddings endpoint input/output of vllm

Need to optionally set

export EMBEDDINGS_USE_VLLM=true

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Test locally with API successfully

curl http://localhost:8888/v1/chatqna     -H "Content-Type: application/json"     -d '{
        "messages": "What is the revenue of Nike in 2023?"
    }'
data: b''

data: b' As'

data: b' of'

data: b' now'

data: b','

data: b' the'

data: b' exact'

data: b' revenue'

data: b' of'

data: b' N'

data: b'ike'

data: b' for'

data: b' '

data: b'2'

data: b'0'

data: b'2'

data: b'3'

data: b' is'

data: b' not'

data: b' available'

data: b'.'

data: b' However'

data: b','

data: b' you'

data: b' can'

data: b' find'

data: b' the'

data: b' latest'

data: b' revenue'

data: b' information'

data: b' by'

data: b' searching'

data: b' for'

data: b' their'

data: b' financial'

data: b' reports'

data: b' or'

data: b' visiting'

data: b' their'

data: b' official'

data: b' website'

data: b'.'

data: b''

data: b''

data: [DONE]

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @raravena80

raravena80 and others added 5 commits December 6, 2024 14:06
Signed-off-by: Ricardo Aravena <[email protected]>
Co-authored-by: root <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sihan Chen <[email protected]>
Signed-off-by: Ricardo Aravena <[email protected]>
@raravena80
Copy link
Author

Reopened here due to DCO failing: #1237

@raravena80 raravena80 closed this Dec 7, 2024
@raravena80 raravena80 deleted the patch-1 branch December 7, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants