Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null value_file judgment #1470

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Fix null value_file judgment #1470

merged 5 commits into from
Feb 6, 2025

Conversation

ZePan110
Copy link
Collaborator

@ZePan110 ZePan110 commented Jan 26, 2025

Description

Fix null value_file judgment.

Issues

Issue link: https://github.com/opea-project/GenAIExamples/actions/runs/12934103512

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Test: Manually trigger AvatarChatbot Helmtest
Link: https://github.com/opea-project/GenAIExamples/actions/runs/12969896213
Status: When the valuefile does not exist, no failed work will be generated.
Test: Nightly test
Links: https://github.com/opea-project/GenAIExamples/actions/runs/12985648054
Status: passed
Test: Docker image scan test
Links: https://github.com/opea-project/GenAIExamples/actions/runs/12985537974
Status: passed

@ZePan110 ZePan110 requested a review from chensuyue as a code owner January 26, 2025 00:55
Copy link

github-actions bot commented Jan 26, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@ZePan110 ZePan110 force-pushed the fix-issue branch 2 times, most recently from 3c28cfa to deb6f2c Compare January 27, 2025 07:26
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvliang-intel lvliang-intel merged commit 44a689b into main Feb 6, 2025
14 checks passed
@lvliang-intel lvliang-intel deleted the fix-issue branch February 6, 2025 09:09
xiguiw pushed a commit to xiguiw/GenAIExamples that referenced this pull request Feb 7, 2025
Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: Malini Bhandaru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants