Enable OpenTelemtry Tracing for ChatQnA on Xeon and Gaudi by docker compose merge feature #1488
+181
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
louie-tsai
force-pushed
the
otlp_enable_chatqna
branch
3 times, most recently
from
d92968e to
baeadf9
Compare
|
What's the performance / latency impact of enabling this feature; e.g. when serviing 1000 parallel users? (I.e. should it be disabled by default, with an option for enabling it?) |
louie-tsai
force-pushed
the
otlp_enable_chatqna
branch
4 times, most recently
from
55380d5 to
498858c
Compare
…new compose_telemetry.yaml files Signed-off-by: Louie, Tsai <[email protected]> Signed-off-by: Tsai, Louie <[email protected]>
louie-tsai
force-pushed
the
otlp_enable_chatqna
branch
from
794a355 to
29a3060
Compare
louie-tsai
changed the title
|
@eero-t |
Spycsh
approved these changes
Feb 7, 2025
Signed-off-by: Tsai, Louie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables OpenTelemetry Tracing for vllm and tgi on both Xeon and Gaudi by docker compose merge feature.
By default, it is disable and it could be enabled by docker compose an additional compose_telemetry.yaml file.
docker compose -f compose.yaml -f compose_telemetry.yaml up -dIt helps to tracing microservice performance for each request.
PR#1046 is related to this PR.
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
NA
Tests
Manually test on Azure Xeon instance