Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for llava-tgi-service being started rather than healthy #1490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashahba
Copy link
Collaborator

@ashahba ashahba commented Feb 1, 2025

Description

For some reason, llava-tgi-service never becomes healthy and the dependent services within VisualQnA fail to start and eventually docker compose -d up fails on CPU.
This is probably a subtle bug in the way docker compose healthcheck works.

Issues

Although may not be the exact reason that the user is running into issues here #1479 but it may partially resolve that issue

Type of change

Replace docker compose readiness condition service_started instead of service_healthy

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

N/a

Tests

I can successfully start the services and make curl calls to the microservice(s).

Copy link

github-actions bot commented Feb 1, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@Spycsh
Copy link
Member

Spycsh commented Feb 5, 2025

I cannot reproduce the issue that llava-tgi-service never becomes healthy on my Xeon server. Could you docker logs llava-tgi-service and show whether it ends with router/src/server.rs:2354: Connected, which means the service is up successfully?

1479 is about VideoQnA, rather than VisualQnA? So this PR cannot solve 1479, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants