[WIP] Estimate system requirement by using Intel perfspect for CI/CD and Documents #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
louie-tsai
requested review from
chensuyue
and removed request for
lvliang-intel and
letonghan
louie-tsai
changed the title
louie-tsai
changed the title
|
Some comments for this feature:
|
chensuyue
reviewed
Feb 11, 2025
| # get used disk | ||
| list="$(./perfspect/perfspect report --filesystem 2>&1)" | ||
| list=$( for i in ` echo $list `; do [[ $i =~ json ]] && echo $i ; done ) | ||
| used_disk_before="$(python parse_perfspect.py $list 2>&1)" |
There was a problem hiding this comment.
Line 181 to line 186 could be part of parse_perfspect.py, since it's common used for all examples.
chensuyue
reviewed
Feb 11, 2025
| if [[ "$IMAGE_REPO" == "opea" ]]; then build_docker_images; fi | ||
| start_time=$(date +%s) | ||
| start_services | ||
| end_time=$(date +%s) | ||
| duration=$((end_time-start_time)) | ||
| echo "Mega service start duration is $duration s" && sleep 1s | ||
|
|
||
| # trace max used memory | ||
| list="$(./perfspect/perfspect telemetry --duration 10 2>&1)" |
There was a problem hiding this comment.
Line 196 to line 198 could be part of parse_perfspect.py, since it's common used for all examples.
chensuyue
reviewed
Feb 11, 2025
| # get used disk | ||
| list="$(./perfspect/perfspect report --filesystem 2>&1)" | ||
| list=$( for i in ` echo $list `; do [[ $i =~ json ]] && echo $i ; done ) | ||
| used_disk_after="$(python parse_perfspect.py $list 2>&1)" |
chensuyue
reviewed
Feb 11, 2025
| @@ -0,0 +1,47 @@ | |||
| # Copyright (C) 2025 Intel Corporation | |||
There was a problem hiding this comment.
This is a common used scripts, it's better to be in the first project level.
chensuyue
reviewed
Feb 11, 2025
| @@ -193,6 +206,16 @@ function main() { | |||
| # validate_frontend | |||
There was a problem hiding this comment.
We can use another megaservice_stress test to record the memory usage, which can cover the max running memory I mentioned. We can have a mode=perfspect for this condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate system requirement check with Intel PerfSpect Tool in CI/CD test scripts to get minimum system requirement for ChatQnA and then other samples as next step
https://github.com/intel/PerfSpect
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
Intel PerfSpect
Tests