Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard: smoother notifications translations (fixes #4853) #4890

Merged
merged 13 commits into from
Jan 6, 2025
Merged

dashboard: smoother notifications translations (fixes #4853) #4890

merged 13 commits into from
Jan 6, 2025

Conversation

deeppp15
Copy link
Member

@deeppp15 deeppp15 commented Dec 17, 2024 •
edited
Loading

Description

Note

  • This change is for new notifications. Older notifications will still not get translated

Test

  • Create new notifications like pending surveys or add resources to library

Screenshots

Spanish notifications
language translation changes

Avinash-Codes
Avinash-Codes requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@Avinash-Codes Avinash-Codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the contents of .kt and .kt.lite are uniform.

@deeppp15 deeppp15 marked this pull request as ready for review December 21, 2024 06:25
@deeppp15 deeppp15 changed the title translated strings and lang check dashboard: smoother translated notifications (fixes #4853) Dec 23, 2024
@deeppp15 deeppp15 requested a review from Okuro3499 December 23, 2024 23:03
@dogi dogi changed the title dashboard: smoother translated notifications (fixes #4853) dashboard: smoother notifications translations (fixes #4853) Dec 30, 2024
@dogi dogi merged commit 938917a into master Jan 6, 2025
2 checks passed
@Okuro3499 Okuro3499 deleted the 4853-translate-notifications branch January 7, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avinash-Codes Avinash-Codes Avinash-Codes approved these changes

@Okuro3499 Okuro3499 Okuro3499 approved these changes

@dogi dogi dogi approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

translate notifications
4 participants
@deeppp15 @dogi @Okuro3499 @Avinash-Codes