Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8sclusterreceiver] change k8s.node.condition* metrics unit to empty #27586

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[k8sclusterreceiver] change k8s.node.condition* metrics unit to empty #27586

merged 1 commit into from
Oct 10, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Oct 10, 2023 •
edited
Loading

Description:

Change k8s.node.condition_* metrics units to be empty.

Link to tracking Issue:

Testing:

  • Updated tests

Documentation:

@povilasv povilasv changed the title [k8sclusterreceiver] change k8s.node.condition_ metric unit to empty [k8sclusterreceiver] change k8s.node.condition* metric unit to empty Oct 10, 2023
@povilasv povilasv changed the title [k8sclusterreceiver] change k8s.node.condition* metric unit to empty [k8sclusterreceiver] change k8s.node.condition* metrics unit to empty Oct 10, 2023
@povilasv povilasv marked this pull request as ready for review October 10, 2023 12:33
@povilasv povilasv requested a review from a team October 10, 2023 12:33
@TylerHelmuth
Copy link
Member

@povilasv I'd take this change as is, but it would be even better if node was switched to using mdatagen first.

@dmitryax dmitryax merged commit 14055f5 into open-telemetry:main Oct 10, 2023
@github-actions github-actions bot added this to the next release milestone Oct 10, 2023
@povilasv povilasv mentioned this pull request Oct 11, 2023
Closed
@povilasv
Copy link
Contributor Author

povilasv commented Oct 11, 2023 •
edited
Loading

@povilasv I'd take this change as is, but it would be even better if node was switched to using mdatagen first.

Since this is merged ,made an issue for it #27617

@povilasv povilasv deleted the k8sclusterreceiver-node-condition branch October 11, 2023 09:00
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@povilasv @jmsnll
[k8sclusterreceiver] change k8s.node.condition* metrics unit to empty (…
40361fe 
…open-telemetry#27586)

Change k8s.node.condition_* metrics units to be empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
receiver/k8scluster
Projects
None yet
Milestone
v0.87.0
Development

Successfully merging this pull request may close these issues.
4 participants
@povilasv @TylerHelmuth @dmitryax @MovieStoreGuy