-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/encoding] support skywalkingencoding extension #36968
Open
JaredTan95
wants to merge
16
commits into
open-telemetry:main
Choose a base branch
from
JaredTan95:skywalkingencoding_extension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[extension/encoding] support skywalkingencoding extension #36968
JaredTan95
wants to merge
16
commits into
open-telemetry:main
from
JaredTan95:skywalkingencoding_extension
+742
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredTan95
requested review from
atoulme,
dmitryax,
MovieStoreGuy and
a team
as code owners
December 27, 2024 06:19
github-actions
bot
added
cmd/otelcontribcol
otelcontribcol command
extension/encoding
labels
Dec 27, 2024
JaredTan95
changed the title
[extension/encoding] suuport Skywalkingencoding extension
[extension/encoding] support skywalkingencoding extension
Dec 27, 2024
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
JaredTan95
force-pushed
the
skywalkingencoding_extension
branch
from
December 27, 2024 06:28
8d1b0e5
to
b01b7a1
Compare
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
atoulme
reviewed
Dec 27, 2024
@@ -90,11 +90,12 @@ extension/awsproxy/ @open-telemetry/collector-cont | |||
extension/basicauthextension/ @open-telemetry/collector-contrib-approvers @jpkrohling @frzifus | |||
extension/bearertokenauthextension/ @open-telemetry/collector-contrib-approvers @jpkrohling @frzifus | |||
extension/cgroupruntimeextension/ @open-telemetry/collector-contrib-approvers @mx-psi @rogercoll | |||
extension/encoding/ @open-telemetry/collector-contrib-approvers @atoulme @dao-jun @dmitryax @MovieStoreGuy @VihasMakwana | |||
extension/encoding/ @open-telemetry/collector-contrib-approvers @atoulme @dao-jun @dmitryax @MovieStoreGuy @VihasMakwana @JaredTan95 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do this in a separate pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
kafkareceiver
supportsjaeger
andzipkin
protocol traces, and can also receive skywalkng traces viaskywalkingreceiver
.From the practical use of skywalking, we often use kafka to host large-scale traces data. However,
kafka receiver
does not supportskywalking encoding
currently.with this PR, we can fectch skywalking traces and parse it into
otlp
traces:Link to tracking issue
Fixes #28693
Testing
Documentation