skip file permission test on windows

open-telemetry · Aug 21, 2024 · 0954dd4 · 0954dd4
1 parent 56ec03b
commit 0954dd4
Showing 1 changed file with 24 additions and 19 deletions.
diff --git a/cmd/builder/internal/builder/main_test.go b/cmd/builder/internal/builder/main_test.go
@@ -228,12 +228,13 @@ func TestSkipGenerate(t *testing.T) {
 
 func TestGenerateAndCompile(t *testing.T) {
 	replaces := generateReplaces()
-	testCases := []struct {
-		testCase    string
-		cfgBuilder  func(t *testing.T) Config
-		verifyFiles func(t *testing.T, dir string)
-		expectedErr string
-	}{
+	type testDesc struct{
+                testCase    string
+                cfgBuilder  func(t *testing.T) Config
+                verifyFiles func(t *testing.T, dir string)
+                expectedErr string
+        }
+	testCases := []testDesc{
 		{
 			testCase: "Default Configuration Compilation",
 			cfgBuilder: func(t *testing.T) Config {
@@ -384,19 +385,6 @@ func TestGenerateAndCompile(t *testing.T) {
 				return cfg
 			},
 		},
-		{
-			testCase: "No Dir Permissions",
-			cfgBuilder: func(t *testing.T) Config {
-				cfg := newTestConfig()
-				err := cfg.SetBackwardsCompatibility()
-				require.NoError(t, err)
-				cfg.Distribution.OutputPath = t.TempDir()
-				assert.NoError(t, os.Chmod(cfg.Distribution.OutputPath, 0400))
-				cfg.Replaces = append(cfg.Replaces, replaces...)
-				return cfg
-			},
-			expectedErr: "failed to generate source file",
-		},
 		{
 			testCase: "Invalid Output Path",
 			cfgBuilder: func(t *testing.T) Config {
@@ -429,6 +417,23 @@ func TestGenerateAndCompile(t *testing.T) {
 		},
 	}
 
+	// file permissions don't work the same on windows systems, so this test always passes.
+	if runtime.GOOS != "windows" {
+		testCases = append(testCases, testDesc{
+                        testCase: "No Dir Permissions",
+                        cfgBuilder: func(t *testing.T) Config {
+                                cfg := newTestConfig()
+                                err := cfg.SetBackwardsCompatibility()
+                                require.NoError(t, err)
+                                cfg.Distribution.OutputPath = t.TempDir()
+                                assert.NoError(t, os.Chmod(cfg.Distribution.OutputPath, 0400))
+                                cfg.Replaces = append(cfg.Replaces, replaces...)
+                                return cfg
+                        },
+                        expectedErr: "failed to generate source file",
+                })
+	}
+
 	for _, tt := range testCases {
 		t.Run(tt.testCase, func(t *testing.T) {
 			cfg := tt.cfgBuilder(t)