-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[configtelemetry] Add a read header timeout of 10s on the configtelemetry Prometheus HTTP server #10675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10675 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 406 406
Lines 18998 18999 +1
=======================================
+ Hits 17411 17412 +1
Misses 1227 1227
Partials 360 360 ☔ View full report in Codecov by Sentry. |
@codeboten given that you created the issue, please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably ok, but it's not solving the original issue correct? the places in the code that were triggering the lint failure are still unchanged?
no this solves one of the lint failures, and the others are plugged via confighttp changes. |
See this commit and change for the other place where this occurs: https://github.com/open-telemetry/opentelemetry-collector/pull/10275/files#diff-1fadfcd3b4194004717150126d27e8a32fdaa8292ca99e81a937d26abe0998faR351 |
Thanks @atoulme, can G112 be removed then? https://github.com/open-telemetry/opentelemetry-collector/pull/5700/files |
…etry Prometheus HTTP server
This reverts commit c3a3160.
6e52b49
to
eaf740d
Compare
@codeboten it appears so! I have reverted the commit and added it to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Description
Add 10s read header timeout on the configtelemetry Prometheus HTTP server.
Link to tracking issue
Fixes #5699