Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configtelemetry] Add a read header timeout of 10s on the configtelemetry Prometheus HTTP server #10675

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jul 20, 2024

Description

Add 10s read header timeout on the configtelemetry Prometheus HTTP server.

Link to tracking issue

Fixes #5699

@atoulme atoulme requested review from a team and TylerHelmuth July 20, 2024 02:05
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (88b3153) to head (f095848).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10675   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         406      406           
  Lines       18998    18999    +1     
=======================================
+ Hits        17411    17412    +1     
  Misses       1227     1227           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme
Copy link
Contributor Author

atoulme commented Jul 25, 2024

@codeboten given that you created the issue, please take a look?

@mx-psi mx-psi requested a review from codeboten August 1, 2024 11:06
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably ok, but it's not solving the original issue correct? the places in the code that were triggering the lint failure are still unchanged?

@atoulme
Copy link
Contributor Author

atoulme commented Aug 7, 2024

no this solves one of the lint failures, and the others are plugged via confighttp changes.

@atoulme
Copy link
Contributor Author

atoulme commented Aug 7, 2024

@codeboten
Copy link
Contributor

@atoulme atoulme force-pushed the add_default_timeout branch from 6e52b49 to eaf740d Compare August 7, 2024 19:31
@atoulme
Copy link
Contributor Author

atoulme commented Aug 7, 2024

@codeboten it appears so! I have reverted the commit and added it to the PR.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@mx-psi mx-psi merged commit 2c9229d into open-telemetry:main Aug 8, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ReadHeaderTimeout values
3 participants