Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][docs/rfc] Add RFC on confmap Provider configuration goals #10776

Merged

Conversation

evan-bradley
Copy link
Contributor

@evan-bradley evan-bradley commented Jul 31, 2024

Description

This is a stripped-down version of #10121 that eschews implementation details in favor of answering questions about what we want to achieve instead of how we will achieve it. A section from that PR has been reproduced here to cover a few approaches for future discussions.

@evan-bradley evan-bradley requested review from a team and songy23 July 31, 2024 20:32
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (65e6be6) to head (54a7622).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10776   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         406      406           
  Lines       18985    18985           
=======================================
  Hits        17398    17398           
  Misses       1227     1227           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi requested review from mx-psi and dmitryax August 2, 2024 09:13
@mx-psi
Copy link
Member

mx-psi commented Aug 7, 2024

@dmitryax PTAL!

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit 94199c8 into open-telemetry:main Aug 7, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants