[chore] [exporterhelper] Remove redundant Marshal methods from test structs #8286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method was removed from the Request interface in open-telemetry#8178, so the implementation on the test structs is not required anymore
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8286 +/- ##
==========================================
+ Coverage 90.18% 90.22% +0.03%
==========================================
Files 302 302
Lines 15859 15859
==========================================
+ Hits 14303 14309 +6
+ Misses 1261 1256 -5
+ Partials 295 294 -1 ☔ View full report in Codecov by Sentry. |
dmitryax
changed the title
bogdandrutu
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method was removed from the Request interface in #8178, so the implementation on the test structs is not required anymore