Add Rust native symbolization library and C API wrapper #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christos68k
force-pushed
the
ck/symblib
branch
from
1f1e3bb to
74bd1c1
Compare
christos68k
changed the title
christos68k
force-pushed
the
ck/symblib
branch
from
74bd1c1 to
8ea9b7b
Compare
rockdaboot
approved these changes
Dec 12, 2024
girodav
approved these changes
Dec 12, 2024
|
nit: Can we add |
This commit adds the Rust native symbolization framework that we developed at Elastic and now making available in OpenTelemetry as part of the ebpf-profiler project. We can use it to implement automatic on-target symbolization of native binaries (e.g. Go executables) but also to enable an OpenTelemetry bulk native symbol upload protocol. Co-authored-by: Joel Höner <[email protected]> Co-authored-by: Victor Michel <[email protected]> Co-authored-by: Florian Lehner <[email protected]> Co-authored-by: Tim Rühsen <[email protected]> Co-authored-by: Davide Girardi <[email protected]>
christos68k
force-pushed
the
ck/symblib
branch
from
b19f1ed to
9bec392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Rust native symbolization framework that we developed at Elastic and now making available in OpenTelemetry as part of the
ebpf-profilerproject. We can use it to implement automatic on-target symbolization of native binaries (e.g. Go executables) but also to enable an OTel bulk native symbol upload protocol that we (Profiling SIG) can come together and specify.Building through Cargo works and all tests are passing.
NOTE: This is the initial PR that introduces the Rust symbolization framework but does not resolve packaging and artifact questions. We may decide to split this out into a separate repository post-merge.