Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation/http/otelhttp): move client metrics creation into internal semconv package #6002

Merged
merged 15 commits into from
Oct 10, 2024

run precommit

7a12e97
Select commit
Loading
Failed to load commit list.
Merged

feat(instrumentation/http/otelhttp): move client metrics creation into internal semconv package #6002

run precommit
7a12e97
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 15, 2024 in 0s

65.6% (+0.0%) compared to d0309dd

View this Pull Request on Codecov

65.6% (+0.0%) compared to d0309dd

Details

Codecov Report

Attention: Patch coverage is 98.18182% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.6%. Comparing base (d0309dd) to head (7a12e97).
Report is 8 commits behind head on main.

Files Patch % Lines
...tion/net/http/otelhttp/internal/semconv/v1.20.0.go 96.7% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6002   +/-   ##
=====================================
  Coverage   65.6%   65.6%           
=====================================
  Files        204     203    -1     
  Lines      12974   12975    +1     
=====================================
+ Hits        8522    8523    +1     
- Misses      4198    4199    +1     
+ Partials     254     253    -1     
Files Coverage Δ
instrumentation/net/http/otelhttp/common.go 100.0% <ø> (ø)
instrumentation/net/http/otelhttp/handler.go 91.9% <100.0%> (+1.8%) ⬆️
...entation/net/http/otelhttp/internal/semconv/env.go 92.0% <100.0%> (+3.3%) ⬆️
instrumentation/net/http/otelhttp/transport.go 94.0% <100.0%> (-1.0%) ⬇️
...tion/net/http/otelhttp/internal/semconv/v1.20.0.go 93.0% <96.7%> (+1.8%) ⬆️

... and 1 file with indirect coverage changes