Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: Add EventName #6187

Merged
merged 7 commits into from
Jan 22, 2025
Merged

log: Add EventName #6187

merged 7 commits into from
Jan 22, 2025

Conversation

pellared
Copy link
Member

@pellared pellared commented Jan 21, 2025

Fixes #6182
Towards #6184

Towards #6181

Prior-art: #6018

@pellared pellared marked this pull request as ready for review January 21, 2025 09:46
@pellared pellared changed the title log: Add EventName support log: Add EventName Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (e108415) to head (2b00918).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6187     +/-   ##
=======================================
- Coverage   82.2%   82.2%   -0.1%     
=======================================
  Files        273     273             
  Lines      23720   23729      +9     
=======================================
+ Hits       19521   19526      +5     
- Misses      3852    3855      +3     
- Partials     347     348      +1     

see 4 files with indirect coverage changes

@pellared pellared self-assigned this Jan 21, 2025
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be added to the SDK as well? (or is that for a later PR?)

@pellared
Copy link
Member Author

pellared commented Jan 21, 2025

Should it be added to the SDK as well? (or is that for a later PR?)

Separate issue (and PR): #6183

You can find the breakdown here: #6181

I do not want to make this PR too big. I even hesitated to add enhancements to logtest but found out that this is PR should be still easy to review.

@pellared pellared merged commit 185547c into open-telemetry:main Jan 22, 2025
32 checks passed
@pellared pellared deleted the api-evt-name branch January 22, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add EventName to Logs API
3 participants